dMZX Forums: MOD SAM does not work -> Archived MegaZeux Bugs -> Tracker

// FIXME - There may be no way to get this to work.
// It may have to be removed.

Heh. Heh. Heh. Heh.

Updating status to: Flagged For Future Version

If we're going to do ANYTHING about this (we haven't looked all that hard at it), we aren't going to do anything about it for 2.84 regardless.

Updating version to: 2.84


I'm going to root out this stupid fucking tracker bug if it's the last thing I do.

nnnngghghh

Updating version to: 2.84

KILL YOU

Back on topic: who uses MOD SAM anyway? I wonder if we could compile a list of games that actually used it somewhere along the line... in BBH's thread two games alone were mentioned.

Updating status to: Confirmed

Woa 2.85 is gonna fix a lot of bugz />

Updating status to: Flagged For Future Version

But not this one, it seems, as this relies on us switching to xmp, and xmp doesn't support row getting/seeking.

Updating status to: Closed - No Change

I've added support for MOD SAM in libxmp in the branch add-mod-sam.

The behavior libxmp exhibits will use instruments instead of samples in modules with instruments (undefined behavior in DOS, because MODs and GDMs did not), and will loop samples/instruments if they have looping enabled in the module (inconsistent with DOS; in the version of Stuffyou City with MOD SAM, the pacman power pellet sound effect will repeat indefinitely with libxmp).

Only two games ever used MOD SAM, one of which (Stuffyou City) has been updated in the vault to not use it. We can't support all sound engines with this, and there's no guarantee that it will behave the same between the engines that do support it. And finally, we could use that command index for something more deserving in debytecode.

It's highly unlikely this will make it into a release of MegaZeux.

Moving to: Archived MegaZeux Bugs

I'm deleting this branch, so here's all relevant code that was added in that branch for reference:

audio/audio.c

void spot_sample(int freq, int sample)
{
  if(audio.primary_stream && audio.primary_stream->spot_sample)
  {
    LOCK();
    audio.primary_stream->spot_sample(audio.primary_stream,
     (freq_conversion / freq) / 2, (unsigned int)sample);
    UNLOCK();
  }
}

audio/audio_xmp.c

static void audio_xmp_spot_sample(struct audio_stream *a_src,
 Uint32 frequency, Uint32 sample)
{
  // Convert frequency to nearest chromatic note
  int note = (int)(12.0 * log(frequency / 523.3) / log(2) + .5);

  xmp_smix_play_instrument(((struct xmp_stream *)a_src)->ctx,
   (int)sample, note, 64, 0);
}

(in the xmp destruct function before xmp_end_player)

  xmp_end_smix(((struct xmp_stream *)a_src)->ctx);

(in the xmp init function after xmp_set_player)

    xmp_start_smix(ctx, 1, 0);

Moving to: MegaZeux Bugs

Updating status to: Fixed
Issue fixed in: 2.92

Wow, this issue is a roller coaster ride. MOD SAM has been reimplemented in GIT 138b37c8 for libxmp builds. It's not perfect (currently samples won't e.g. fade out with the playing mod) but it's better than the SMIX implementation I posted before and seems to do good enough for Crisis in Stuffyou City and Sprite Catcher (haven't tested Talon's Tale much yet).

Moving to: Archived MegaZeux Bugs

This command has been fixed for games that implemented it in the past. It will not be supported for any world made past 2.70.