dMZX Forums: Call-time pass-by-reference usage in forum code -> dMZX Forums -> Tracker

Jump to content

Report ID 795 Title Call-time pass-by-reference usage in forum code
Product dMZX Forums Status Confirmed (Severity 5 - Critical)

Page 1 of 1
  • Cannot start a new Issue
  • You cannot reply to this issue

Issue Timeline Issue Timeline
Report ID #795: Call-time pass-by-reference usage in forum code

#1 User is offline  
Lachesis 

  • the pinnacle of human emotion
  • Group: DigiStaff
  • Posts: 3,895
  • Joined: 17-July 04
  • Gender:Female
  • Location:Sealand

Posted 02 January 2020 - 10:52 PM

The forum code is littered with uses of call-time pass-by-reference, which is a liability for us because it keeps us trapped on old copies of PHP. So far the main instances seem to be these:

admin/sources/base/core.php line 1284 defines the function "doDataHooks" which was universally used with call-time pass-by-reference instead of having a reference in the definition. Fixing this function and updating all uses of it got most of the forums working past PHP 5.3.

admin/applications_addon/tracker/modules_public/post/post.php line 159 used one when registering the post class. It's not clear if removing this broke anything (yet).

Still keeping an eye out for other uses of this feature. It'd be really nice to be able to permanently upgrade PHP to something reasonable.
"Let's just say I'm a GOOD hacker, AND virus maker. I'm sure you wouldn't like to pay for another PC would you?"

xx̊y (OST) - HELLQUEST (OST) - Zeux I: Labyrinth of Zeux (OST) (DOS OST)
w/ Lancer-X and/or asgromo: Pandora's Gate - Thanatos Insignia - no True(n) - For Elise OST
MegaZeux: Online Help File - Keycode Guide - Joystick Guide - Official GIT Repository

Page 1 of 1  
  • Cannot start a new Issue
  • You cannot reply to this issue

Replies (1 - 1)

#2 User is offline  
Lachesis 

  • the pinnacle of human emotion
  • Group: DigiStaff
  • Posts: 3,895
  • Joined: 17-July 04
  • Gender:Female
  • Location:Sealand

Posted 14 May 2020 - 12:23 AM

Looks like this is used in quite a few places in an older version of the bug tracker and one of those usages survived into the current version's custom fields code. Fixed.
"Let's just say I'm a GOOD hacker, AND virus maker. I'm sure you wouldn't like to pay for another PC would you?"

xx̊y (OST) - HELLQUEST (OST) - Zeux I: Labyrinth of Zeux (OST) (DOS OST)
w/ Lancer-X and/or asgromo: Pandora's Gate - Thanatos Insignia - no True(n) - For Elise OST
MegaZeux: Online Help File - Keycode Guide - Joystick Guide - Official GIT Repository

Page 1 of 1
  • Cannot start a new Issue
  • You cannot reply to this issue

0 User(s) are reading this issue
0 Guests and 0 Anonymous Users


Powered by IP.Tracker 1.3.2 © 2025  IPS, Inc.