dMZX Forums: String compares prior to 2.81 used strcasecmp() -> Archived MegaZeux Bugs -> Tracker

Prior to 2.81, string comparisons used strcasecmp, and some games rely on this: Mines of Madness (#68874).

At some point, null termination of string values was removed. Versions from 2.81 onward replaced the strcasecmp with strncasecmp combined with a hacky check that returns the difference in lengths if the result is 0, and 2.81c further replaced strncasecmp with an endian-unsafe compare (and moved the length comparison first, breaking comparison for strings of different lengths). The bugs from these changes have since been fixed.

This could be fixed by having an alternate compare_strings implementation (without exact case/wildcard checks) that checks the next byte after the compare for \0 before returning -1/1. Since there are already version checks in string comparison it's doubtful checking this would add much (if any) overhead right now. I'd like to wait to see if anything else is found affected by this before patching it, but in any case it's a low-hanging fix for the next bugfix release.

Updating status to: Fixed
Issue fixed in: 2.92d

Fixed in GIT 1012da07.

Moving to: Archived MegaZeux Bugs