[Old-Sckool]

Been working on a small mzx project, and I have noticed that reading directories being really slow. I'm not doing something stupidly wrong am I?

. "open_dir opens a subdirectory"
. "up_dir opens the parent directory if it has permission"
. "top_dir opens the top-level directory"

color c11
set "$dir_s&dir_s&" to "."
inc "dir_s" by 1


: "set_dir"
set "f" to 0
set "file" to 0
set "dir" to 1
set "ui_dir" to 0
set "ui_file" to 0
set "$dir0" to ".."

set "$dir" to ""
loop start
inc "$dir" by "&$dir_s('loopcount')&"
inc "$dir" by "/"
loop for "('dir_s'-1)"

set "&$dir&" to "fread_open"

: "readdir_l"
set "$buffer" to "fread"
if "$buffer.length" = 0 then "readdir_s"
set "$f&f&" to "$buffer"
inc "f" by 1
goto "readdir_l"

: "readdir_s"
set "" to "fread_open"
if "f" != 0 then "#sortfiles"
end

: "open_dir"
if "$newdir" = ".." then "up_dir"
set "$dir_s&dir_s&" to "$newdir"
inc "dir_s" by 1
set "scroll_new_list_event" to 1
goto "set_dir"

: "up_dir"
if "dir_s" = 1 then "end"
dec "dir_s" by 1
set "scroll_new_list_event" to 1
goto "set_dir"

: "end"
end


: "#sortfiles"
loop start
set "$f" to "$f&loopcount&"
set "&$dir&/&$f&" to "fread_open"
set "fread_pos" to -1
if "fread_pos" = -1 then "sortfiles_s"
if "fread_pos" = 0 then "sortfiles_dir"

set "$file&file&" to "$f"
inc "file" by 1
goto "sortfiles_s"

: "sortfiles_dir"
set "$" to "fread"
if "$.length" = 0 then "sortfiles_s"

set "$dir&dir&" to "$f"
inc "dir" by 1

: "sortfiles_s"
set "" to "fread_open"
loop for "('f'-1)"
goto "#return"

Attached File(s)

•  Mod Player 2.mzx (16.19K)
  Number of downloads: 2

[Dr Lancer-X]

i assume commands isn't really low or anything like that

in which case it looks fine and maybe opening lots of files is slow for some reason? if so that's a shame because it makes what you're doing infeasible. in c etc you'd use stat to find out if something's a dir, so this wouldn't be something i've tried to do before

i'll try running it when i get home

EDIT: just tested it and i don't know what the performance problem is

the initial directory, my main mzx directory takes a little bit to load, but it's only a tiny fraction of a second (for a dir with 1102 files and dirs in it) and the subdirs i tried load instantly. that sort of delay seems pretty reasonable, especially to open and close that many files

what sort of load are you testing it on and what sort of delays are you experiencing?

[Lachesis]

sounds like commands is low or your drive is really slow

[Old-Sckool]

welp, my system is dead

[Giel]

My main MZX directory only loads slowly due to the fact that I have alot of MZX related files in it. Though it only loads slowly a couple times, then it loads up quickly. Depends on the length of how long the MZX session is anyway. Course, its not TOO slow anyway. especially considering my current machine is an 1.6 GHz Dual Core laptop.

This post has been edited by Giel: 22 March 2015 - 11:00 PM